Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] resource_booking: avoid unexpected keyword argument error #132

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

[12.0][FIX] resource_booking: avoid unexpected keyword argument error #132

wants to merge 1 commit into from

Conversation

cubells
Copy link
Member

@cubells cubells commented Jul 5, 2024

Missing argument in unlink method.

This is fixed in upper versions.

@OCA-git-bot
Copy link
Contributor

Hi @yajo,
some modules you are maintaining are being modified, check this out!

@joscanog
Copy link

joscanog commented Jul 5, 2024

LGTM

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jul 8, 2024
@pedrobaeza pedrobaeza changed the title [FIX] resource_booking: avoid unexpected keyword argument error [12.0+[FIX] resource_booking: avoid unexpected keyword argument error Jul 8, 2024
@pedrobaeza pedrobaeza changed the title [12.0+[FIX] resource_booking: avoid unexpected keyword argument error [12.0][FIX] resource_booking: avoid unexpected keyword argument error Jul 8, 2024
pedrobaeza
pedrobaeza approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in https://github.com/odoo/odoo/blob/ba1ba88874e2ae9716e59ec199eb739d58c3f771/addons/calendar/models/calendar.py#L1738

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-132-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 8, 2024
@OCA-git-bot
Merge PR #132 into 12.0
af91c0d 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-132-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 10, 2024
@OCA-git-bot
Merge PR #132 into 12.0
b19f6d1 
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-132-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 26, 2024
@OCA-git-bot
Merge PR #132 into 12.0
1d52c4e 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joscanog joscanog joscanog approved these changes

@MiguelPoyatos MiguelPoyatos MiguelPoyatos approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved bot is merging ⏳ ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cubells @OCA-git-bot @joscanog @pedrobaeza @MiguelPoyatos